Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/Modify auto-generation of config.yaml in empty directory #114

Open
ishantanu opened this issue Aug 27, 2019 · 0 comments
Open

Remove/Modify auto-generation of config.yaml in empty directory #114

ishantanu opened this issue Aug 27, 2019 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ishantanu
Copy link
Member

Describe the bug
When tk8 is run in a directory which does not have config.yaml, it tries to auto generate it by saying:

No default config was provided. Generating one for you.

The auto-generated config.yaml is only usable for aws provisioner and not for others.

To Reproduce
Steps to reproduce the behavior:

  1. Download tk8 binary in empty folder.
  2. Setup cattle-aws cluster without config.yaml: tk8 cluster install cattle-aws

Expected behavior
We have two options in this case:

  1. Instead of auto-generating config.yaml, we should tell the user to create the config.yaml before running the command since we cannot generate multiple configs for multiple provisioners.

  2. Implement the code for mapping between different config.yaml's for different provisioners.

@ishantanu ishantanu added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Aug 27, 2019
@ishantanu ishantanu changed the title Remove auto-generation of config.yaml in empty directory Remove/Modify auto-generation of config.yaml in empty directory Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant