Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tekton V2 compiler: gather user data on how the exit handler should represent #1392

Open
Tomcli opened this issue Oct 19, 2023 · 4 comments
Open
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Tomcli
Copy link
Member

Tomcli commented Oct 19, 2023

/kind bug

What steps did you take and what happened:
For the exit handler example, the Tekton version right now treat it as a failed pipeline and stop all task scheduling. However, the Argo version simply skip the exit handler dag and continue the pipeline as a succeed pipeline. We need to get some user feedbacks and data on which way they prefer the exit handler should behave.

Currently the Tekton implementation follows the Tekton finally logic and Argo is just skipping the whole exit handler sub-dag. Both are viable implementation which we need some feedbacks from actual users.

What did you expect to happen:

Additional information:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Python Version (use python --version):
  • SDK Version:
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):
@Tomcli
Copy link
Member Author

Tomcli commented Oct 19, 2023

/help

@google-oss-prow
Copy link

@Tomcli:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot added the help wanted Extra attention is needed label Oct 19, 2023
@Tomcli
Copy link
Member Author

Tomcli commented Oct 19, 2023

fyi @yhwang

@yhwang
Copy link
Member

yhwang commented Oct 26, 2023

Some updates:

  • fail-op is a regular task and it should not be inside the finally of a PipelineRun. The current implementation is reasonable.
  • The major difference between Argo v2 and Tekton v2 is the pipeline with a failed task has a different final status
    • In Tekton, the final status is Failed
    • In Argo, the final status is Succeeded

@Tomcli Tomcli changed the title Tekton V2 compiler should put finally graph components inside finally instead of regular tekton tasks Tekton V2 compiler: gather user data on how the exit handler should represent Oct 26, 2023
@Tomcli Tomcli added enhancement New feature or request and removed kind/bug labels Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants