Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub token permission to remove unused ones #2180

Open
1 task done
fharper opened this issue May 16, 2024 · 1 comment
Open
1 task done

Update GitHub token permission to remove unused ones #2180

fharper opened this issue May 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@fharper
Copy link
Member

fharper commented May 16, 2024

Which version of kubefirst are you using?

2.4.8

Which cloud provider?

None specific

Which DNS?

None specific

Which installation type?

None specific

Which distributed Git provider?

GitHub

Did you use a fork of gitops-template?

No

Which Operating System?

None specific

What is the issue?

The GitHub token permission don't need:

  • admin:org_hook as we already have the admin:repo_hook which is enough for our needs since we do not need organization level hook. This one need to be tested just to be sure.
  • admin:ssh_signing_key as we don't sign the code committed by kbot. It is used internally, but it doesn't need to be needed for the user.

Once the check for those permissions are moved, we also need to update the docs at https://docs.kubefirst.io/common/gitAuth to reflect that.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@fharper fharper added the bug Something isn't working label May 16, 2024
@fharper
Copy link
Member Author

fharper commented May 16, 2024

So Jared told me we may not check the permissions in the preflight check, so once we validate that, we can just update the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant