-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using GitHub actions as CI would help with contributing and pull-request #110
Comments
sbuerk
added a commit
to sbuerk/eloquent-model-generator
that referenced
this issue
Mar 11, 2023
This change introduces GitHub action workflows to integrate automatic CI checks for pushes and pull requests. This change adds a general php-linting for supported php-versions and executes unit- and integration tests against laravel 9.x and 10.x. This helps contributors a lot, and also helps the maintainer(s) for pull-requests, that tests are green. Maybe this helps to minimze manual work for pull-request reviews and increases merging working pull-requests. Resolves krlove#110
sbuerk
added a commit
to sbuerk/eloquent-model-generator
that referenced
this issue
Mar 11, 2023
This change introduces GitHub action workflows to integrate automatic CI checks for pushes and pull requests. This change adds a general php-linting for supported php-versions and executes unit- and integration tests against laravel 9.x and 10.x. This helps contributors a lot, and also helps the maintainer(s) for pull-requests, that tests are green. Maybe this helps to minimze manual work for pull-request reviews and increases merging working pull-requests. Resolves krlove#110
sbuerk
added a commit
to sbuerk/eloquent-model-generator
that referenced
this issue
Mar 11, 2023
This change introduces GitHub action workflows to integrate automatic CI checks for pushes and pull requests. This change adds a general php-linting for supported php-versions and executes unit- and integration tests against laravel 9.x and 10.x. This helps contributors a lot, and also helps the maintainer(s) for pull-requests, that tests are green. Maybe this helps to minimze manual work for pull-request reviews and increases merging working pull-requests. Resolves krlove#110
sbuerk
added a commit
to sbuerk/eloquent-model-generator
that referenced
this issue
Mar 11, 2023
This change introduces GitHub action workflows to integrate automatic CI checks for pushes and pull requests. This change adds a general php-linting for supported php-versions and executes unit- and integration tests against laravel 9.x and 10.x. This helps contributors a lot, and also helps the maintainer(s) for pull-requests, that tests are green. Maybe this helps to minimze manual work for pull-request reviews and increases merging working pull-requests. Resolves krlove#110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This package contains some unit- and integration tests.
Sadly, they are not executed automatically on pushes and
for pull-requests, which opens for the possibility to miss
broken tests.
GitHub action workflow file should be added executing at least:
against supported laravel and php versions.
In further follow-ups this may be extended to use other database
backends for the integration test, and not only sqlite.
The text was updated successfully, but these errors were encountered: