Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrecognized name: learning_rate for matrix factorization #23

Open
Startouf opened this issue Oct 13, 2021 · 3 comments
Open

Unrecognized name: learning_rate for matrix factorization #23

Startouf opened this issue Oct 13, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@Startouf
Copy link

While running a matrix factorization model, I ran into the error

Unrecognized name: learning_rate

Maybe it is related to #5

packages:
  - package: dbt-labs/dbt_utils
    version: [">=0.7.0"]
  - package: tnightengale/dbt_meta_testing
    version: [">0.3.1", "<0.4.0"]
  - package: dbt-labs/codegen
    version: [">=0.4.0", "<0.5.0"]
  - package: kristeligt-dagblad/dbt_ml
    version: 0.5.0

And dbt 0.20.2

@Startouf
Copy link
Author

Yes the culprit is there
https://github.com/kristeligt-dagblad/dbt_ml/blob/master/macros/hooks/model_audit.sql#L24

Matrix factorization uses the default data in the hooks, but it should not

@rbjerrum rbjerrum added the bug Something isn't working label Oct 18, 2021
@juszzz
Copy link

juszzz commented Jan 4, 2022

@Startouf do you know if there's a workaround? I just encountered this today as well.

@Startouf
Copy link
Author

Startouf commented Jan 4, 2022

You could look at the code and try to override the macro definition (and eventually make a PR with that) it's not very difficult to exclude the learning_rate, it's just that there may be other variables to exclude, so it requires either several trials or to read the doc appropriately, I had started along the trials way, but I have other priorities and I'm doing it bit by bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants