Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message containing only emojis rendered as image #1515

Open
marekvospel opened this issue Dec 9, 2024 · 4 comments
Open

Message containing only emojis rendered as image #1515

marekvospel opened this issue Dec 9, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@marekvospel
Copy link
Contributor

Bug Description

If a message contains only custom emojis, their corners are rounded. (as if they were an image / sticker)
image

Steps to Reproduce

  • Add custom emoji
  • Send message only containing one or two emojis
  • Observe

Expected Behavior

Custom emojis should not have cut corners (and possibly for parity with normal emoji only message should be bigger)

App Version

1.23.0

Additional Platform Information

Firefox, Android

Additional Context

No response

@marekvospel marekvospel added the bug Something isn't working label Dec 9, 2024
@marekvospel
Copy link
Contributor Author

From my testing the event is of type MessageTypes.Text, event.onlyEmotes = true and event.numberEmotes = 2.
I'll try to look into it and make a PR.

@marekvospel
Copy link
Contributor Author

marekvospel commented Dec 9, 2024

Ah, makes sense, the same cropping is happening with normal emojis (and all noBubble events), however because of

fontSize: bigEmotes ? fontSize * 5 : fontSize,
the effect is not as visible. (Also emojis in most fonts probably aren't fully colored squares, but have some padding themselves)

marekvospel added a commit to marekvospel/fluffychat that referenced this issue Dec 9, 2024
@marekvospel
Copy link
Contributor Author

What do you think about 0de6a4b?
image

It fixes this problem, however the code isn't the prettiest and I feel like it might get overlooked in future changes. Do you think there is a better way?

Also should I look into bigEmojis for custom emojis in the same PR, or should I make a separate issue and PR?

@marekvospel
Copy link
Contributor Author

What do you think about 0de6a4b?
image

It fixes this problem, however the code isn't the prettiest and I feel like it might get overlooked in future changes. Do you think there is a better way?

Also should I look into bigEmojis for custom emojis in the same PR, or should I make a separate issue and PR?

@krille-chan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant