Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete person icon is visible for the unauthorized user roles who don't have person delete permission. #1196

Open
saroarhossain57 opened this issue Aug 5, 2023 · 2 comments
Labels
change request Enhancement New feature or request. Fix Proposed When pull request is proposed for the issue. Fixed Bug fixed.

Comments

@saroarhossain57
Copy link

Bug report

馃敂 Delete person icon is visible for the unauthorized user roles who don't have person delete permission.

If I log in as any other user role and that user role doesn't have permission to delete a person but still I can see the delete button although the delete button does not delete the user and as expected there is an error message about permission. I think it should hide the delete button if the user doesn't have permission to delete any person from the table.

Screencast for the issue.

Watch Video

Steps to reproduce

Here is how you can reproduce the issue

1. Add a new user with anything other user role like Editor.
2. Remove contact delete permission for that role.
3. Login with that newly created user.
4. Go to the contacts page and see there is a delete button showing that you have disabled the delete permission.

I would love to fix the issue and I will send a PR very shortly.

Thanks
Saroar Hossain

@saroarhossain57
Copy link
Author

Hello There!

I have created a PR by fixing the issue I have mentioned here.

Pull Request 馃敟 #1197

@prabhat-webkul prabhat-webkul added change request Fix Proposed When pull request is proposed for the issue. Enhancement New feature or request. labels Mar 20, 2024
@komal-sh-27
Copy link
Collaborator

I have checked this PR #1197 and it is working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change request Enhancement New feature or request. Fix Proposed When pull request is proposed for the issue. Fixed Bug fixed.
Projects
None yet
Development

No branches or pull requests

3 participants