Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit button open new tab on Persons, Product, Organization #1148

Open
luisogandob opened this issue Jan 13, 2023 · 1 comment
Open

Edit button open new tab on Persons, Product, Organization #1148

luisogandob opened this issue Jan 13, 2023 · 1 comment
Assignees
@harshit-webkul
Labels
Bug Something isn't working. Fix Proposed When pull request is proposed for the issue. Fixed Bug fixed.
Milestone
v1.2.4

Comments

@luisogandob
Copy link
Contributor

Bug report

Issue Description

When you clic edit button the label is set to target='_blank' so it will open a new tab for every edited record.

Steps to reproduce

  1. Edit any record in Persons/Product/Organization

Expected result

  • Same behavior as Add New.

Actual result

  • Open new tab with the record to Edit
@Sanjaybhattwebkul Sanjaybhattwebkul self-assigned this Jan 16, 2023
@Sanjaybhattwebkul Sanjaybhattwebkul added Bug Something isn't working. In Progress Resolving the issue is in progress. labels Jan 16, 2023
@Sanjaybhattwebkul Sanjaybhattwebkul added this to the v1.2.4 milestone Jan 16, 2023
Sanjaybhattwebkul added a commit to Sanjaybhattwebkul/laravel-crm that referenced this issue Jan 16, 2023
@Sanjaybhattwebkul
issue krayin#1148 fixed
fa5b7d7
@Sanjaybhattwebkul Sanjaybhattwebkul mentioned this issue Jan 16, 2023
Merged
@Sanjaybhattwebkul Sanjaybhattwebkul added Fix Proposed When pull request is proposed for the issue. and removed In Progress Resolving the issue is in progress. labels Jan 16, 2023
jitendra-webkul added a commit that referenced this issue Apr 20, 2023
@jitendra-webkul
Merge pull request #1150 from Sanjaybhattwebkul/remove-target-blank
3555864 
issue #1148 fixed
@komal-sh-27
Copy link
Collaborator

I have checked this PR #1150 and it is working fine. Also, merged in master branch.

@komal-sh-27 komal-sh-27 added the Fixed Bug fixed. label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshit-webkul harshit-webkul

Labels
Bug Something isn't working. Fix Proposed When pull request is proposed for the issue. Fixed Bug fixed.
Projects
None yet
Milestone
v1.2.4
Development

No branches or pull requests
4 participants
@luisogandob @komal-sh-27 @Sanjaybhattwebkul @harshit-webkul