-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement garbage collecting of old issues #98
Comments
I'm gonna use the |
@rashadg1030 This issue is a bit more complicated. Open issues should never be deleted, no matter how old they are. Old here means is no longer open. So you need to fetch all closed issues and delete all of them from our DB. |
@chshersh got it, make sense. Now how do I determine if an issue in the DB has closed or not? Do I just fetch all closed Haskell issues and delete the ones that match in the DB? |
Yep, exactly. This should work for now. But architecture behind this implementation is not that straightforward. If you will repeatably call |
@chshersh Can you explain why |
Well, it's just bad in general for performance to do concurrently batch updates of different types and perform SELECT queries on a single time very fast. I'm not sure, but there's a chance that our sync can be very fast (like 5-20 minutes or even faster). Updating table with such frequency might be a high load for DB. But now I think that we don't need to do concurrent garbage collecting (this was my implicit assumption at first). The algorithm can be:
|
@chshersh Sounds good |
This will require to fetch all closed issues and delete all closed issues from our database.
The text was updated successfully, but these errors were encountered: