From bfbf22eae42a0f7c237e6a47c049d46f194160b1 Mon Sep 17 00:00:00 2001
From: Jonas Drotleff <jonas.drotleff@3j14.de>
Date: Sun, 5 Jan 2025 02:21:09 +0100
Subject: [PATCH] ssh kitten: Fix zsh shell integration expanding variables in
 title

Remove usage of the `-P` option from the print inside the
`_ksi_precmd` and `_ksi_preexec` functions. Instead, the result of
`builtin print -Pn "%m"` is stored in the local variable `hostname`.
This mitigates accidental expansion of variables in the command to be
executed.

Fixes #8193.
---
 shell-integration/zsh/kitty-integration | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/shell-integration/zsh/kitty-integration b/shell-integration/zsh/kitty-integration
index a9dbb7f854..c297800794 100644
--- a/shell-integration/zsh/kitty-integration
+++ b/shell-integration/zsh/kitty-integration
@@ -268,10 +268,15 @@ _ksi_deferred_init() {
 
         if [[ "$is_ssh_session" == "y" ]]; then
             # show the hostname via %m for SSH sessions
+            builtin local hostname="$(builtin print -Pn "%m")"
+            # The variable `hostname` is used such that we don't have to use
+            # the -P option in the two print commands below. This mitigating
+            # accidental variable expansion, e.g. of the variables in the
+            # command string (V).
             functions[_ksi_precmd]+="
-                builtin print -Prnu $_ksi_fd \$'\\e]2;'\"%m: \${(%):-%(4~|…/%3~|%~)}\"\$'\\a'"
+                builtin print -rnu $_ksi_fd \$'\\e]2;'\"$hostname: \${(%):-%(4~|…/%3~|%~)}\"\$'\\a'"
             functions[_ksi_preexec]+="
-                builtin print -Prnu $_ksi_fd \$'\\e]2;'\"%m: \${(V)1}\"\$'\\a'"
+                builtin print -rnu $_ksi_fd \$'\\e]2;'\"$hostname: \${(V)1}\"\$'\\a'"
         else
             functions[_ksi_precmd]+="
                 builtin print -rnu $_ksi_fd \$'\\e]2;'\"\${(%):-%(4~|…/%3~|%~)}\"\$'\\a'"