Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Socket Outside #110

Open
nishant23122000 opened this issue Apr 10, 2021 · 3 comments
Open

Move Socket Outside #110

nishant23122000 opened this issue Apr 10, 2021 · 3 comments
Assignees

Comments

@nishant23122000
Copy link

Describe the bug
I think we should move all socket.io code outside of index.js in the backend because there is a bunch of socket.io events happening in index.js.

To Reproduce

Expected result
We can create an object of the socket in the socket.js file which we store in Utils folder So I think it's easy to understand index.js code and also code will be refactored in proper structure

Actual result

Screenshots

Are you willing to contribute to this issue? Yes

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 89.0.4389.114

Smartphone (please complete the following information):

Additional context

@Vishv07
Copy link
Contributor

Vishv07 commented Apr 10, 2021

Your point seems realistic. @nishant23122000 this will help us in extending the socket in the future @kothariji

@nishant23122000
Copy link
Author

@Vishv07 Yes

@kothariji kothariji added GSSOC21 Level2 Bug fixing, adding small features. (level 2) labels Apr 10, 2021
@kothariji
Copy link
Owner

Hi @nishant23122000 , First of all, thank you so much for taking out the time to work on this issue.

Definitely 🙌, Please go forward to work on this issue. I am assigning this Issue to you 👍

And last but not least,
Keep Contributing 🙏🔥

@kothariji kothariji linked a pull request Apr 15, 2021 that will close this issue
@kothariji kothariji removed GSSOC21 Level2 Bug fixing, adding small features. (level 2) labels Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants