Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracker] Split tests into multiple file tests #2750

Open
3 of 7 tasks
johnnv1 opened this issue Jan 23, 2024 · 2 comments
Open
3 of 7 tasks

[Tracker] Split tests into multiple file tests #2750

johnnv1 opened this issue Jan 23, 2024 · 2 comments
Labels
code heatlh 💊 Improvement the package code health Difficulty: easy Describes the difficulty of an issue to be solved help wanted Extra attention is needed
Milestone

Comments

@johnnv1
Copy link
Member

johnnv1 commented Jan 23, 2024

Currently, we have some test files that have all (or almost all) tests of a module within a single file, the ideal here is to split these cases into multiple test files. Which file should be testing a single functionality, or file of our library.

Example:

We have now a single file testing almost all losses functions https://github.com/kornia/kornia/blob/c5558ac2c03bbbbbbb6c9f82616b8d5229398f1a/tests/losses/test_losses.py we would like to have a single test file for each loss. What would mirror the file organization of the losses module of kornia https://github.com/kornia/kornia/tree/c5558ac2c03bbbbbbb6c9f82616b8d5229398f1a/kornia/losses

This issue will work as a tracker to map some of these files that need to be split, feel free to help us find others and/or help us split them into multiple files.

The goal here is to reorganize our test suite. If you have any questions, you can call us and/or ask on our Slack page too Slack

Originally posted by @edgarriba in #2745 (comment)


You can choose anyone below, or find new ones. You don't have to worry about separating all the tests in a file into a single PR

@johnnv1 johnnv1 added this to the kornia v0.8.0 milestone Jan 23, 2024
@johnnv1 johnnv1 added help wanted Extra attention is needed Difficulty: easy Describes the difficulty of an issue to be solved code heatlh 💊 Improvement the package code health labels Jan 23, 2024
@marvlyngkhoi
Copy link
Contributor

marvlyngkhoi commented Feb 11, 2024

@johnnv1 I'll help splitting the losses test into their individual loss file and can you help point me to the testing docs so that I can run the tests after I've done splitting the file thanks.

@marvlyngkhoi
Copy link
Contributor

@johnnv1 I have split the test losses into different inidividual files and linking the PR here for you to check once your free
https://github.com/kornia/kornia/pull/2801.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code heatlh 💊 Improvement the package code health Difficulty: easy Describes the difficulty of an issue to be solved help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants