Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all namespaces and helm charts show up #166

Open
rashid4lyf opened this issue Jan 3, 2023 · 5 comments
Open

Not all namespaces and helm charts show up #166

rashid4lyf opened this issue Jan 3, 2023 · 5 comments
Labels
-★- Favorite item

Comments

@rashid4lyf
Copy link

rashid4lyf commented Jan 3, 2023

Description

We have deployed this onto a large cluster with over 300 helm charts however only 256 helm charts appear. We can see that in the request to get all namespaces, all namespaces are returned from the cluster (355 namespaces). However, some of these are not displayed as there are apparently no helm charts found which does not seem to be the case.

Is there a limit on the number of helm charts it can show or some known issue?

Screenshots

No response

Additional information

No response

@harshit-mehtaa
Copy link
Contributor

Adding pagination might help here as in an instance only a specific set will be queried and loaded

@undera
Copy link
Collaborator

undera commented Jan 3, 2023

The 256 releases is a Helm default limit that we'll need to address either with higher limit or with pagination. It needs a fix in the code.

Infinite number of releases might be a wrong strategy, we should detect when we are hitting some limit and offer to narrow display down with namespace filter. TBD

The place where it originates from: https://github.com/helm/helm/blob/main/cmd/helm/list.go#L55

@rashid4lyf
Copy link
Author

Thank you so much for the quick response! I think pagination would work well from a user experience point of view. Also, I assume one way to get around the limit is to show all namespaces and when you click on a namespace it would then find the charts for the given namespace?

@harshit-mehtaa
Copy link
Contributor

@undera
Should we add pagination to1.x release? It would be easier to handle it using React on the frontend side
WDYT?

@undera
Copy link
Collaborator

undera commented Jan 5, 2023

I'm still in doubts. IMO pagination is wrong, 'cause you usually have idea about what you are looking for. It's either string pattern, or a namespace.
We can detect when there is more charts than we display, and suggest narrowing down the search. In this way, we'll have also to make filtering on backend, as opposed to current frontend way.
It definitely would need to wait for React

@undera undera added the -★- Favorite item label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-★- Favorite item
Projects
None yet
Development

No branches or pull requests

3 participants