Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containers such as MKV can have mismatched video and audio length #11

Open
kokseen1 opened this issue Jun 12, 2022 · 0 comments
Open

Containers such as MKV can have mismatched video and audio length #11

kokseen1 opened this issue Jun 12, 2022 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@kokseen1
Copy link
Owner

Possible solutions:

  • Pad audio to match video before generating keys
    • Perform comparison between self.mediainfo["duration"] and len(self.audio_raw) to check for mismatch
    • Should have no issue if video is shorter than audio, video will be padded by ffmpeg automatically
  • Convert to mp4 before generating keys
  • Generate audio key using more reliable methods (e.g. shared key)

TODO:

  • Always export keys unless specified otherwise with flag
  • Prioritize audio_length from keyfile over audio_length from audio track
@kokseen1 kokseen1 added bug Something isn't working enhancement New feature or request labels Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant