Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: dialog box shadow (dark mode) #340

Open
FlameWolf opened this issue Aug 10, 2023 · 2 comments
Open

Feature request: dialog box shadow (dark mode) #340

FlameWolf opened this issue Aug 10, 2023 · 2 comments

Comments

@FlameWolf
Copy link

Dialog elements having a box-shadow of 0 0 0 1px var(--border) will be helpful in dark mode. See attached image for comparison:

water-css-dialog

@FlameWolf
Copy link
Author

FlameWolf commented Aug 10, 2023

Or, the backdrop colour can be updated in dark mode:

@media (prefers-color-scheme: dark) {
	dialog::backdrop {
		background: rgba(255, 255, 255, 0.61);
	}
}

Or for both modes:

dialog::backdrop {
	background: rgba(144, 149, 156, 0.5);
}

Additionally, I'm wondering why dialog has a darker BG colour anyway, since it's going to be painted over a backdrop layer. The darker background makes form controls look dimmer, as can be observed in the above screenshot.

@Ajay-308
Copy link

Ajay-308 commented Oct 8, 2023

hey can you assign this issue to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants