Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Misleading Withdraw Amount wording in Offers #11239

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Dec 11, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

if the trade is active: Cancel Offer/Swap
if the trade is expired: Withdraw Amount has been changed to Withdraw Offer/Swap, should this also be red ?

pls don't merge without @exezbcz 's green light

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-12-11 at 11 23 02@2x

QA

CleanShot.2024-12-11.at.11.31.59.mp4
CleanShot.2024-12-11.at.11.29.40.mp4

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4fac6f0
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/67592d87003d86000867768f
😎 Deploy Preview https://deploy-preview-11239--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Dec 11, 2024

@hassnian hassnian changed the title fix: Misleading Withdraw Amount wording in Offers fix: Misleading Withdraw Amount wording in Offers Dec 11, 2024
@hassnian hassnian marked this pull request as ready for review December 11, 2024 06:27
@hassnian hassnian requested a review from a team as a code owner December 11, 2024 06:27
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team December 11, 2024 06:27
@Jarsen136 Jarsen136 requested a review from exezbcz December 11, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading Withdraw Amount wording in Offers
1 participant