Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️☣️‼️ brooming out minimark v0.1 #11235

Draft
wants to merge 48 commits into
base: main
Choose a base branch
from

Conversation

vikiival
Copy link
Member

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Removing minimark to optimize bundle size + removing legacy complex code.
This PR removes dependency on Interaction as it is now exported from static

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 99a011f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6758b5b5c34179000885356d
😎 Deploy Preview https://deploy-preview-11235--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vikiival vikiival changed the title :warn: brooming out minimark v0.1 ⚠️☣️‼️ brooming out minimark v0.1 Dec 10, 2024
Copy link

sonarcloud bot commented Dec 10, 2024

Copy link

Deploying koda-art-prod with  Cloudflare Pages  Cloudflare Pages

Latest commit: 99a011f
Status: ✅  Deploy successful!
Preview URL: https://78c34758.kodaart-production.pages.dev
Branch Preview URL: https://feat-brooming-out-minimark.kodaart-production.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant