feat: edit collection permission #11217
Conversation
Jarsen136
requested review from
preschian and
hassnian
and removed request for
a team
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Please use normal price input
|
✅ Updated |
components/collection/EditModal.vue
Outdated
|
|
||
| <div> | ||
| <div class="flex justify-between"> | ||
| <p>{{ $t('mint.collection.permission.noPriceSet') }}</p> |
There was a problem hiding this comment.
after setting a price this did not change
There was a problem hiding this comment.
Updated. This text will be changed after toggling.
| watchEffect(async () => { | ||
| const { apiInstance } = useApi() | ||
| const api = await apiInstance.value | ||
| const config = await api.query.nfts.collectionConfigOf(collectionId) | ||
| const mintSettings = (config.toHuman() as { mintSettings: CollectionMintSetting }).mintSettings | ||
| mintSettings.price = mintSettings.price?.replaceAll(',', '') | ||
| collectionPermissionSettings.value = mintSettings | ||
| }) |
There was a problem hiding this comment.
since this was added lets disable the edit collection button if !collectionMetadata
components/collection/EditModal.vue
Outdated
| } | ||
|
|
||
| const COLLECTION_MINTING_TYPES_OPTIONS = ['Issuer', 'Public', 'HolderOf'].map(type => ({ value: type as CollectionMintSettingType, text: type })) |
There was a problem hiding this comment.
maybe ?
| const COLLECTION_MINTING_TYPES_OPTIONS = ['Issuer', 'Public', 'HolderOf'].map(type => ({ value: type as CollectionMintSettingType, text: type })) | |
| const COLLECTION_MINTING_TYPES_OPTIONS = (['Issuer', 'Public', 'HolderOf'] as CollectionMintSettingType[] ).map(type => ({ value: type, text: type })) |
There was a problem hiding this comment.
~ incorrect impl
-
It does not make sense to have issuer & price :) (will you pay for yourself?)
-
Setting public & set price > 0 means that you wont be able to mint on koda
2.1 Warning that setting public will allow anyone to mint into your collection -
Holder of is missing search input where user can select which collection is eligible.
3.1 Warning that by setting type to holder of user wont be able to mint on koda
Thanks for providing more details. A question about the |
Yes, you are completely right, I apologize for my mistake. (I have edited the comment) I meant Why search input? Well if you take it from perspective of artist / @JustLuuuu they have no idea what |
|
I know what a collection ID is! But its true that artists don't know it 😂 |
Updated 
|
|
no price has been set but i can still submit, if the switch is not meant to be clickable we should hide it
after pressing save changes
|
|
Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs QA check
Context
Screenshot 📸
ref: https://wiki.polkadot.network/docs/learn-nft-pallets