Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Evm Can't transfer or burn your own NFT #11220

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Dec 8, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Screenshot 📸

  • My fix has changed something on UI;

Sub

CleanShot 2024-12-08 at 06 46 18@2x

Evm

CleanShot 2024-12-08 at 06 43 55@2x

Copy link

netlify bot commented Dec 8, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 340cfe5
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6758f608cb796400082bec83
😎 Deploy Preview https://deploy-preview-11220--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

# Conflicts:
#	components/common/itemTransfer/ItemTransferModal.vue
#	components/gallery/GalleryItemButton/GalleryItemMoreActionBtn.vue
@hassnian hassnian marked this pull request as ready for review December 8, 2024 03:51
@hassnian hassnian requested a review from a team as a code owner December 8, 2024 03:51
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team December 8, 2024 03:51

return isEthereumAddress(address1)
? isSameAddressEvm(address1, address2)
: isSameAddressSubstrate(address1, address2)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we solve it by this?

Suggested change
}
return addressEq(address1.toLowerCase(), address2.toLowerCase())

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope

CleanShot 2024-12-11 at 07 22 46@2x

# Conflicts:
#	components/items/ItemsGrid/ItemsGridImage.vue
#	components/profile/ProfileDetail.vue
Copy link

sonarcloud bot commented Dec 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evm Can't transfer or burn your own NFT
2 participants