Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Price sort by logic #8890

Open
exezbcz opened this issue Jan 6, 2024 · 8 comments · May be fixed by #11075
Open

Price sort by logic #8890

exezbcz opened this issue Jan 6, 2024 · 8 comments · May be fixed by #11075
Assignees
@hassnian
Labels
A-collection work being done collection view A-explorer p2 core functionality, or is affecting 60% of app UX first Improvement for UX

Comments

@exezbcz
Copy link
Member

exezbcz commented Jan 6, 2024

so, currently, our price filter, either low to high or high to low only work when buy now filter is applied

i don't know what tunel vision I had, but it should work differently

image

changes

  • since its "sort by" it should actually sort without any other filter applied
  • when the low to high filter is active, show listed first, sorted by the sort by filter, and then leave the rest untouched. It takes all the supply and just reorders it so the listed ones are on top.
  • then, when "buy now" is active as well, it filters out only the listed

sort by price + buy now = listed items sorted by price

sort by price = all items sorted based on price, non listed are there as well, but only after the listed ones

lets also rename "buy now" to listed

price range should work the same

image

  • it does not show the ones with 1 dot first

probably this needs to be changed, sorry for that
@exezbcz exezbcz added UX first Improvement for UX p2 core functionality, or is affecting 60% of app A-collection work being done collection view A-explorer labels Jan 6, 2024
@exezbcz exezbcz mentioned this issue Jan 6, 2024
Closed
@hassnian
Copy link
Contributor

hassnian commented Jan 9, 2024

👋

@kodabot
Copy link
Collaborator

kodabot commented Jan 9, 2024

ASSIGNED - @hassnian 🔒 LOCKED -> Wednesday, January 10th 2024, 21:46:45 UTC -> 36 hours

This was referenced Jan 9, 2024
Closed
Closed
@exezbcz exezbcz mentioned this issue Jan 12, 2024
Open
@yangwao
Copy link
Member

yangwao commented Jan 22, 2024

we can reflect here to have sort buy now from low to high as default

@exezbcz exezbcz mentioned this issue Feb 26, 2024
Open
@yangwao
Copy link
Member

yangwao commented Mar 11, 2024 •
edited
Loading

we can reflect here to have sort buy now from low to high as default

can it be done without doing

@exezbcz
Copy link
Member Author

exezbcz commented May 6, 2024

Possible to finish?

cc @hassnian @vikiival

@vikiival
Copy link
Member

vikiival commented May 6, 2024

Possible to finish?

Hey we are waiting for a release of - subsquid/squid-sdk#270

cc @eldargab can know more

@exezbcz
Copy link
Member Author

exezbcz commented Jun 7, 2024 •
edited
Loading

cc @kodadot/internal-dev

any takers here? not prio - deadline end of month

@vikiival
Copy link
Member

vikiival commented Jun 7, 2024

Imo old @hassnian's PR can be reopened

@hassnian hassnian mentioned this issue Jun 22, 2024
Closed
6 tasks
@hassnian hassnian linked a pull request Oct 2, 2024 that will close this issue
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hassnian hassnian

Labels
A-collection work being done collection view A-explorer p2 core functionality, or is affecting 60% of app UX first Improvement for UX
Projects
None yet
Milestone
No milestone
5 participants
@yangwao @vikiival @hassnian @exezbcz @kodabot