Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply genart filter for Collections on koda.art #10991

Open
vikiival opened this issue Sep 17, 2024 · 23 comments · May be fixed by #11045
Open

Apply genart filter for Collections on koda.art #10991

vikiival opened this issue Sep 17, 2024 · 23 comments · May be fixed by #11045
Assignees
Labels
A-explorer enhancement New feature or request

Comments

@vikiival
Copy link
Member

Is your feature request related to a problem?

Currently we see the all collections on Polkadot assethub in koda.art platform.
This is not nice because we would like to see only genart

Describe the solution you would like

if you visit (subdomain).koda.art there should be a default filter applied for collection explore { kind_eq: genart }

{
  collectionEntities(where: { kind_eq: genart }) {
    id
    name
    kind
    meta {
      kind
    }
  }
}

Describe alternatives you have considered

I have considered to add this also to NFTentities
lmk @kodadot/internal-dev

Also this could be added as optional to existing queries so lmk if you need help with that

Screenshots

Screenshot 2024-09-17 at 09 22 25

Are there opened related issues?

@vikiival vikiival added the enhancement New feature or request label Sep 17, 2024
@vikiival
Copy link
Member Author

This is available only on ahp yet,

  • base, mnt will be released today
  • ahk will be released this week

@Jarsen136 Jarsen136 self-assigned this Sep 17, 2024
@Jarsen136
Copy link
Contributor

I have considered to add this also to NFTentities lmk

Yes, please add it.
And maybe also some other queries like collectionEntitiesConnection nftEntitiesConnection

@vikiival
Copy link
Member Author

And maybe also some other queries like collectionEntitiesConnection

make sure u are using v14

it is there

{
  collectionEntitiesConnection(where: { kind_eq: genart }, orderBy: id_ASC) {
    totalCount
  }
}

@vikiival
Copy link
Member Author

Which are the cases you would need that for nftEntitiesConnection ?
I am thiking you add it to nftEntities too but would like to hear if it's a valid case

@Jarsen136
Copy link
Contributor

Which are the cases you would need that for nftEntitiesConnection ?

queries/profileStatsById.graphql

profileStatsById {  listed: nftEntitiesConnection, sold: nftEntitiesConnection ... }

Display the correct stats of account, which only shows the stats related to genart.

I am thiking you add it to nftEntities too but would like to hear if it's a valid case

On items explore page, filter nfts that is related to genart maybe.

@vikiival
Copy link
Member Author

vikiival commented Sep 17, 2024

you can apply it from the collection

{
  obtained: nftEntitiesConnection(where: {currentOwner_eq: $id, burned_eq: false, metadata_not_eq: "", issuer_not_in: $denyList, collection: {kind_eq: genart}}, orderBy: name_ASC) {
    totalCount
  }
}

@Jarsen136
Copy link
Contributor

you can apply it from the collection

{
  obtained: nftEntitiesConnection(where: {currentOwner_eq: $id, burned_eq: false, metadata_not_eq: "", issuer_not_in: $denyList, collection: {kind_eq: genart}}, orderBy: name_ASC) {
    totalCount
  }
}

Oh, I see. That's a good idea.

@Jarsen136
Copy link
Contributor

On the items explore page in ahp network, it's using tokenEntityList resolver.
Is it possible to add kind type there? @vikiival

@hassnian
Copy link
Contributor

linking #10763

@Jarsen136
Copy link
Contributor

This is available only on ahp yet,

  • base, mnt will be released today
  • ahk will be released this week

Let me know if you have graphql links for testing other networks.

like ahp: https://ahp.gql.api.kodadot.xyz/ -> https://kodadot.squids.live/speck/v/v14/graphql

@vikiival
Copy link
Member Author

mnt should be updated, base had some issues.
ahk is failing because of cf

@vikiival
Copy link
Member Author

On the items explore page in ahp network, it's using tokenEntityList resolver.

I've tried - kodadot/stick#308

@vikiival
Copy link
Member Author

@Jarsen136

  • flock v3
  • basick v13
  • speck v14

Still trying to fix stick

@vikiival
Copy link
Member Author

Also @Jarsen136

@Jarsen136
Copy link
Contributor

Also @Jarsen136

It produces the intern error : )
image

@Jarsen136
Copy link
Contributor

cc @vikiival

@vikiival
Copy link
Member Author

cc @vikiival

Can you please try to fix the SQL query by opening PR?

You do not need to index it :)

@vikiival
Copy link
Member Author

@Jarsen136 need any help/input from my side?

@Jarsen136
Copy link
Contributor

Jarsen136 commented Sep 29, 2024

@Jarsen136 need any help/input from my side?

Yes.

  1. What's the graphql endpoint url for the ahk network?
  2. When will we release the latest version to the endpoint? so I can remove the hard code from the PR.
    like https://kodadot.squids.live/speck/v/v14/graphql -> https://ahp.gql.api.kodadot.xyz/

@vikiival
Copy link
Member Author

vikiival commented Oct 4, 2024

What's the graphql endpoint url for the ahk network?

https://kodadot.squids.live/stick/v/v12/graphql

all except stick are already running prod version

@Jarsen136
Copy link
Contributor

What's the graphql endpoint url for the ahk network?

https://kodadot.squids.live/stick/v/v12/graphql

Look like there are still some issues on ahk @vikiival

image

@vikiival
Copy link
Member Author

vikiival commented Oct 4, 2024

Yes this is related to the fact that no drops contain genart kind now

@Jarsen136
Copy link
Contributor

Yes this is related to the fact that no drops contain genart kind now

Then I would disable art gen mode for ahk network for now, as it defaults on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-explorer enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants