Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect knope.toml in parent directories #72

Open
Shadow53 opened this issue Feb 19, 2021 · 1 comment · May be fixed by #951
Open

Detect knope.toml in parent directories #72

Shadow53 opened this issue Feb 19, 2021 · 1 comment · May be fixed by #951
Labels
🎸 Feature New feature or request

Comments

@Shadow53
Copy link
Collaborator

I'd like to be able to run dobby without having to be in the exact directory containing the dobby.toml. I may make the last git commit from a child directory, and it would smooth out the workflow to not need to cd.

A couple thoughts:

  • This will include some sort of procdeural check through every parent directory
  • We may want to stop searching after checking the root of the current git repository (git rev-parse --show-toplevel).
  • What about git submodules where the submodule does not have a dobby.toml but the parent repo does?
  • Should there be support for a global dobby.toml, e.g. at ~/.dobby.toml or ~/.config/dobby/dobby.toml? I don't see a need for it, but I am sure someone will come up with something.
  • Related to the previous one: can settings cascade? Does it make sense for them to do so?
@dbanty dbanty added the 🎸 Feature New feature or request label Feb 19, 2021
@dbanty dbanty changed the title Detect dobby.toml in parent directories Detect knope.toml in parent directories Jun 10, 2022
@alex-way
Copy link
Contributor

I'm looking into this and taking an initially naïve approach of recursively checking all parent directories until a knope.toml file is found. I think some of the questions/thoughts in the initial suggestion can be added later as an additional feature.

My questions with the above in mind;

  • Do we want to run the workflow commands from the same directory as the found knope.toml or from the current directory?
  • If there's appetite to support both, I assume we'll need some kind've configuration for the Command workflow step to be able to switch between the two, or perhaps a CLI argument to switch between the default and non-default option?

@alex-way alex-way linked a pull request Mar 19, 2024 that will close this issue
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎸 Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement a way to load configuration recursively from parent alex-way/knope
3 participants
@Shadow53 @alex-way @dbanty