feat: Implement a way to load configuration recursively from parent #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for knope ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Not currently sure how knope loads the I will also say that I'm still very green when it comes to rust so there's probably plenty that can be optimised both in terms of performance & code style, or is just plain wrong. Hopefully it's not too much of an eyesore, or takes too much time to review. |
|
Don’t worry too much about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72
This pull request allows knope to recursively search parent directories for a
knope.tomlfile, using the contents of the configuration if found.An additional option is added and documented for the
Commandworkflow step type;This option controls whether to run the command in the current working directory that the user is in, or alternatively if set to
falsethe first found configuration file in the ancestry path.Known issues
knope.toml#package.versioned_filesattempts to load from the current working directory, rather than the relative path of the configuration file