Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Discovery: Add Variables to EventType V1Beta3 spec #7729

Open
Cali0707 opened this issue Feb 27, 2024 · 2 comments
Open

Event Discovery: Add Variables to EventType V1Beta3 spec #7729

Cali0707 opened this issue Feb 27, 2024 · 2 comments

Comments

@Cali0707
Copy link
Member

Problem
In the new v1beta3 api for eventtypes, we are allowing users to place "variables" into template strings for the various eventtype attributes. It would be good to allow users to give more information about what values are allowed for those variables.

To accomplish this, we can add a variables section to the spec like this:

apiVersion: eventing.knative.dev/v1beta3
kind: EventType
spec:
  reference:
    ...
  attributes:
    - name: "type"
      value: "event.{requestStatus}.foo"
      required: true
    ...
  variables:
    - name: "requestStatus"
      regex: "[a-zA-Z]"
      example: "request.failed"
@Cali0707
Copy link
Member Author

cc @pierDipi @matzew @dsimansk

I'd love to get some feedback on this idea

@Cali0707
Copy link
Member Author

@pierDipi can we discuss this at the WG call this week? I need a decision on how we are planning to proceed here for #7883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant