Not all files to download are visible

[kelson42]

If I search for "bug" online, I get:

If I search for "bug" in library, I get:

I should not get different resulta IMHO, at least not for this search!

[BPerlakiH]

@kelson42 as of my initial findings it seems that we use custom DB query for these results, which is currently searching (in case of this "New" section) only:
- in the names of the ZIM files
- only within those that are not older than 1 month

kiwix-apple/Views/Library/ZimFilesNew.swift

Lines 97 to 109 in 7d4b5b7

	private static func buildPredicate(searchText: String) -> NSPredicate {
	var predicates = [
	NSPredicate(format: "languageCode IN %@", Defaults[.libraryLanguageCodes]),
	NSPredicate(format: "requiresServiceWorkers == false")
	]
	if let aMonthAgo = Calendar.current.date(byAdding: .month, value: -1, to: Date()) {
	predicates.append(NSPredicate(format: "created > %@", aMonthAgo as CVarArg))
	}
	if !searchText.isEmpty {
	predicates.append(NSPredicate(format: "name CONTAINS[cd] %@", searchText))
	}
	return NSCompoundPredicate(andPredicateWithSubpredicates: predicates)
	}

It would be great to know how exactly the website search works, and we can adjust the query to match that.

[BPerlakiH]

I can confirm, that by modifying the search query to use both "name CONTAINS" OR "fileDescription CONTAINS" does return both results. So that solution is working for this specific case:

The only question remains: is that good enough (as it's now a guess how the website search might work), or do we want an exact match ?

[BPerlakiH]

My other, slightly related concern about how the search works is that it's really hard to find a ZIM that is not "new". Currently the user can search only within the selected category (eg. "Other"), but that is a very strict rule, I think. We assume that the user knows which category that ZIM belongs to...
Putting it another way: we have no "global search" (eg: search in all categories).

[kelson42]

Reopening as I believe we should do more than this.

@BPerlakiH Thank you for your englighting comments, I will come back to you

[kelson42]

My other, slightly related concern about how the search works is that it's really hard to find a ZIM that is not "new". Currently the user can search only within the selected category (eg. "Other"), but that is a very strict rule, I think. We assume that the user knows which category that ZIM belongs to...
Putting it another way: we have no "global search" (eg: search in all categories).

@BPerlakiH I agree. Please open an issue just for that and put it in next milestone.

[kelson42]

@BPerlakiH To complete this PR, can you change 1 month in 3 months because 1 month is really too short.

[BPerlakiH]

Increased the lifespan of "NEW" to be 3 months here: #910

[BPerlakiH]

new issue created here: #911

[kelson42]

Seems even more broken thab before now!

[BPerlakiH]

Hmm, interesting. It looks as if the catalog was empty...
I can see both ZIM files as a search result on my end.
Can you try to do a "refresh" with the button:

[kelson42]

Hmm, interesting. It looks as if the catalog was empty...

I can see both ZIM files as a search result on my end.

Can you try to do a "refresh" with the button:

Library is refreshed.

[BPerlakiH]

Did the refresh solve the issue?

[kelson42]

No

[BPerlakiH]

Can you do a screenshot of the "New" section when the search query is empty, and also one screenshot of "Settings > Languages" ?

[BPerlakiH]

Both of those results are in "English" only, so if you do not have English selected, there won't be any result for that query.

[kelson42]

[kelson42]

Works now with latest testflight of this morning... somI guess the fix was still not included. Closing.