Missing string in 3.7.1 donation button

[Popolechien]

A user reported:

The iOS app is missing a string for the newly introduced donate button. My device is in German.
version 3.7.1 Build 204. That’s where the issue appears when donating a custom amount.

See image:

[kelson42]

@BPerlakiH This is urgent and requires s patch release ASAP. We also need to understsnd how this happened exactly.

[BPerlakiH]

@kelson42 I've created a PR for this.
It seems, I forgot to add the .localised part to the usage of this string.
I double checked the other-ones for donation, they are OK in this regard.

[kelson42]

@BPerlakiH Do you now a way to lint this? We should have detected such an error in the CI.

[BPerlakiH]

As for why it happened:
If the string is found by the pure key in the current locale (eg. English), the value for that will be picked up automatically.
If the translation is missing, it will fall back to the key value itself.
What we do, is use this custom extension .localized, that will do the fallback for us to English, if there is no value for the current local (as we don't yet have one for German).

But if we miss to add it, we have this kind of issue, and not just for German, but for all languages, that do not yet have this term.

[BPerlakiH]

I will have a look, if we can automate this check somehow.

[BPerlakiH]

Created a new task for this: #1088
I have a couple of ideas for this, I need to do some experiments to see which is more feasible.