Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS unit tests are still timing out on CI #1081

Open
BPerlakiH opened this issue Jan 17, 2025 · 1 comment · May be fixed by #1082
Open

macOS unit tests are still timing out on CI #1081

BPerlakiH opened this issue Jan 17, 2025 · 1 comment · May be fixed by #1082
Assignees
Labels
Milestone

Comments

@BPerlakiH
Copy link
Collaborator

BPerlakiH commented Jan 17, 2025

GitHub action is still misbehaving with our unit tests running on macOS (times out as never started).
Sometimes it passes for the first time, sometimes it times out, and when re-tried it passes.
It's hard to tell even, when it's fixed, as the former attempt of fixing (to not to use code signing) passed the first time, but then it failed on another PR.

Latest example PR for this:
https://github.com/kiwix/kiwix-apple/actions/runs/12833615870

It failed 3 times, while passed the 4th time without any new commits!

Other GH action users were also complaining about similar issues:
actions/runner-images#6098

Since we are running the very same unit tests on iPhone simulator, which gives us the code coverage, I am proposing to turn them off for macOS, as it's a duplicate run of the exact same tests. The macOS run of them is currently giving us certainly more pain then benefits.

Note: We are still building the app for macOS as part of this process, we just would not run the unit-tests again.

@BPerlakiH BPerlakiH added this to the 3.8.0 milestone Jan 17, 2025
@BPerlakiH BPerlakiH self-assigned this Jan 17, 2025
@BPerlakiH BPerlakiH changed the title macOS unit tests are still failing on CI macOS unit tests are still timing out on CI Jan 17, 2025
@BPerlakiH BPerlakiH linked a pull request Jan 17, 2025 that will close this issue
@BPerlakiH
Copy link
Collaborator Author

BPerlakiH commented Jan 17, 2025

Also it seems to me that GH Action is using some virtual env. magic, which is really slow.
For comparison a clean build on M1 of the macOS Kiwix app is under 30 sec, on GH Action it takes over 3 minutes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant