Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: D&D description is not displayed correctly. #4111

Closed
wants to merge 1 commit into from
Closed

Fixed: D&D description is not displayed correctly. #4111

wants to merge 1 commit into from

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #4087

  • The issue was caused by an HTML entity in the description of the "D&D" ZIM file. The description was displayed as "D&D Wiki" because it was not properly decoded before being set in the TextView.
  • We have now implemented proper decoding of any HTML entities present in the title or description before setting them to the TextView, ensuring the description is displayed correctly.

Screenshot_20241127-163113_Kiwix

@MohitMaliDeveloper @MohitMaliFtechiz
Fixed: D&D description is not displayed correctly.
99feed5 
* The issue was caused by an HTML entity in the description of the "D&D" ZIM file. The description was displayed as "D&D Wiki" because it was not properly decoded before being set in the TextView.
* We have now implemented proper decoding of any HTML entities present in the title or description before setting them to the TextView, ensuring the description is displayed correctly.
@MohitMaliFtechiz MohitMaliFtechiz mentioned this pull request Nov 27, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.76%. Comparing base (2cd2e15) to head (99feed5).

Files with missing lines Patch % Lines
.../kiwixmobile/core/extensions/TextViewExtensions.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #4111      +/-   ##
============================================
- Coverage     58.89%   58.76%   -0.13%     
+ Complexity     1569     1565       -4     
============================================
  Files           316      316              
  Lines         13431    13431              
  Branches       1706     1706              
============================================
- Hits           7910     7893      -17     
- Misses         4385     4402      +17     
  Partials       1136     1136

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Collaborator

Not a bug in Kiwix Android! This nowhere written in the specification that HTML is expected there!

@kelson42 kelson42 closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelson42 kelson42 Awaiting requested review from kelson42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

D&D description is not displayed correctly
3 participants
@MohitMaliFtechiz @kelson42 @MohitMaliDeveloper