Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions that has to be guarded #10

Open
pash7ka opened this issue Jun 21, 2020 · 2 comments
Open

Functions that has to be guarded #10

pash7ka opened this issue Jun 21, 2020 · 2 comments

Comments

@pash7ka
Copy link
Collaborator

pash7ka commented Jun 21, 2020

Functions that has to be guarded:

EarningsTracker

  • burnNFT() I believe this should be called through Proxy

EndowmentFund

  • sendETHtoEscrow() Called from GameManager.bet()
  • contributeKTY() Called from GameCreation.listKittie(), GameManager.participate(), GameManager.bet(), EarningsTracker.burnNFT()
  • contributeETH() Called from GameManager.bet()
  • transferETHfromEscrowWithdrawalPool() Called from WithdrawPool.claimYield()
@innovator256
Copy link
Contributor

@ziweidream if you find any other outliers, please document them here

@ziweidream
Copy link
Collaborator

ziweidream commented Jul 2, 2020 •
edited
Loading

@innovator256 Update two functions releaseKittyGameManager() and acquireKitty() in kittieHELL to using only2Contracts() in commit acf50d8, so the original 4 functions became 2 functions respectively. Updated in both branches (rinkeby5, and guards-and-freezes).

acf50d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pash7ka @innovator256 @ziweidream