[MAINTENANCE] Add tests for Controller package #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-meyer
changed the title
sebastian-meyer
added
🛠 maintenance
oliver-stoehr
force-pushed
the
ControllerTest
branch
from
f31a8fb
to
eb756a2
Compare
sebastian-meyer
modified the milestones:
Kitodo.Presentation 5.0.0,
Kitodo.Presentation 5.1.0
oliver-stoehr
force-pushed
the
ControllerTest
branch
from
8ef040a
to
2f9eb29
Compare
sebastian-meyer
requested changes
Oct 10, 2024
Co-authored-by: Sebastian Meyer <[email protected]>
| foreach ($databaseFixtures as $filePath) { | ||
| $this->importCSVDataSet($filePath); | ||
| } | ||
| $this->persistenceManager = $this->objectManager->get(PersistenceManager::class); |
There was a problem hiding this comment.
This seems to be the problem why the tests fail. $this->objectManager->get() throws the error Call to a member function get() on null, so $this->objectManager isn't initialized.
There was a problem hiding this comment.
This fails because as of version 12 the GeneralUtilityManager is used to get an instance of a class. However, if I change this, all tests fail. The response only contains an empty string. This must be related to the changes to version 12.
$this->persistenceManager = GeneralUtility::makeInstance(PersistenceManager::class);
There was a problem hiding this comment.
Yes, this fixed the issue. Now the tests are running for both, v11 and v12. Unfortunately, some of the tests fail...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for CalendarController will be added in a separate pull request.Update: Added tests for CalendarController in another commit.