Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Two-level metadata: Model and appearance #910

Merged
merged 34 commits into from
Jul 8, 2024

Conversation

chrizzor
Copy link
Collaborator

Extended version of pull request #835

@sebastian-meyer sebastian-meyer added the ⚙ feature A new feature or enhancement. label Feb 10, 2023
@sebastian-meyer sebastian-meyer linked an issue Feb 10, 2023 that may be closed by this pull request
6 tasks
@sebastian-meyer
Copy link
Member

Please rebase this to master and resolve the corresponding conflicts.

@sebastian-meyer
Copy link
Member

I've deployed this branch on https://test.dfg-viewer.de for testing. Examples can be found here.

fraschz and others added 13 commits February 21, 2023 12:53
The Metadata object can now hold entry nodes with a new array containing all subentries.
These are fetched from the subentries table.
* Updated the domain model and repositories to comply with the new DB structure.
* Cleaned up all references to the old table name 'tx_dlf_metadata_subentries'.
* Make 'tx_dlf_metadatasubentries' table accessible for some functions in Hooks/Helper class.
* Extbase class mappings have to be hold as TypoScript _and_ PHP config as long as TYPO3 9 support is not dropped.

In addition, create empty repository class to comply with Extbase conventions.
Also provided IsArrayViewHelper and respect sub-arrays when building $metaCObjData.
Add a TypoScript Wrap field for subentries in database and TCA.
When XPath functions like concat() are used, evaluate() returns a string instead of a DOMNodeList.
@sebastian-meyer
Copy link
Member

I've updated https://test.dfg-viewer.de to the current 1e87169, but this leads to errors: example

Unfortunately there are no messages in the admin log pointing to the cause.

@chrizzor
Copy link
Collaborator Author

I have enabled the detailed error output on the system. It seems that there are problems with the assets. Clearing the cache doesn't help.

@sebastian-meyer
Copy link
Member

OK, the problem was the recent renaming of Resources/Public/Javascript to Resources/Public/JavaScript, because the typoscript configuration of https://github.com/slub/dfg-viewer still addresses the old path. I added a symbolic link for the old directory name and the errors were gone.
Furthermore, I had to disable usage of the internal page proxy because of #908

Classes/Common/Indexer.php Outdated Show resolved Hide resolved
Classes/Common/Indexer.php Outdated Show resolved Hide resolved
Classes/Common/Indexer.php Outdated Show resolved Hide resolved
Classes/Common/MetsDocument.php Outdated Show resolved Hide resolved
Classes/Common/MetsDocument.php Outdated Show resolved Hide resolved
Classes/Common/MetsDocument.php Outdated Show resolved Hide resolved
Classes/Controller/ListViewController.php Outdated Show resolved Hide resolved
Classes/Controller/MetadataController.php Outdated Show resolved Hide resolved
Classes/Domain/Repository/MetadataSubentryRepository.php Outdated Show resolved Hide resolved
Classes/Hooks/DataHandler.php Show resolved Hide resolved
@sebastian-meyer sebastian-meyer changed the base branch from master to project-slub August 8, 2023 05:28
@sebastian-meyer sebastian-meyer changed the base branch from project-slub to 4.x August 8, 2023 05:30
@sebastian-meyer sebastian-meyer changed the base branch from 4.x to master August 8, 2023 05:30
chrizzor and others added 11 commits June 11, 2024 22:17
Classes/Common/Helper.php Outdated Show resolved Hide resolved
Classes/ViewHelpers/IsArrayViewHelper.php Outdated Show resolved Hide resolved
@sebastian-meyer sebastian-meyer changed the base branch from master to musical-sources July 8, 2024 08:25
@sebastian-meyer sebastian-meyer merged commit 41827c0 into kitodo:musical-sources Jul 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙ feature A new feature or enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata grouping/subfields
3 participants