[CUSTOM CODE] [Haven't read docs] Cannot process webhooks

[sachinaugi07]

Receiving malformed webhook request with missing body data when trying to uninstall the shopify app from the store admin dashboard.

webhook route
app.post('/webhooks/:topic', express.text({ type: '*/*' }), shopifyWebhook);

Registering the webhook:-

const webhookRegistrar = async () => {
  shopify.webhooks.addHandlers({
    APP_UNINSTALLED: {
      deliveryMethod: DeliveryMethod.Http,
      callbackUrl: '/webhooks/app_uninstalled',
      callback: async (topic, shop, webhookRequestBody) => {
        const sessionHandler = new SessionStore();
        await sessionHandler.deleteCallback(shop);

        return true;
      },
    },
   });

Webhook controller

const shopifyWebhook = async (req, res) => {
  const { topic } = req.params || '';
  const shop = req.headers['x-shopify-shop-domain'] || '';

  try {
    await shopify.webhooks.process({
      rawBody: req.body,
      rawRequest: req,
      rawResponse: res,
    });
    console.log(`--> Processed ${topic} webhook for ${shop}`);
  } catch (e) {
    console.error(
      `---> Error while registering ${topic} webhook for ${shop}`,
      e
    );
    if (!res.headersSent) {
      res.status(500).send(e.message);
    }
  }
};

module.exports = shopifyWebhook;

[shopify-api/INFO] Receiving webhook request
[shopify-api/DEBUG] Received malformed webhook request | {valid: false, reason: missing_body}
[shopify-api/DEBUG] Webhook request is invalid, returning 400: No body was received when processing webhook
---> Error while registering app_uninstalled webhook for adspostx-swag-shop.myshopify.com InvalidWebhookError: No body was received when processing webhook
    at Object.<anonymous> (/Users/sachinaugustine/sachin/adspostx/api-server/node_modules/@shopify/shopify-api/lib/webhooks/process.js:45:23)
    at Generator.next (<anonymous>)
    at fulfilled (/Users/sachinaugustine/sachin/adspostx/api-server/node_modules/tslib/tslib.js:166:62)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  response: undefined
}

[sachinaugi07]

Using express.json() as body parser have updated the webhook controller code to include req.body as string. But after doing this im getting the hmac error. I have set the api secret in the .env file. Not sure why this is happening. Need some help here.

const shopifyWebhook = async (req, res) => {
  const { topic } = req.params || '';
  const shop = req.headers['x-shopify-shop-domain'] || '';

  try {
    await shopify.webhooks.process({
      rawBody: req.body,
      rawRequest: req,
      rawResponse: res,
    });
    console.log(`--> Processed ${topic} webhook for ${shop}`);
  } catch (e) {
    console.error(
      `---> Error while registering ${topic} webhook for ${shop}`,
      e
    );
    if (!res.headersSent) {
      res.status(500).send(e.message);
    }
  }
};

[shopify-api/DEBUG] Webhook validation failed | {apiVersion: 2022-10, domain: adspostx-swag-shop.myshopify.com, topic: APP_UNINSTALLED, webhookId: 6c22c945-3f5d-482d-bae0-26e7d67f5d2f}
[shopify-api/DEBUG] Webhook request is invalid, returning 401: Could not validate request HMAC
---> Error while registering app_uninstalled webhook for adspostx-swag-shop.myshopify.com InvalidWebhookError: Could not validate request HMAC
    at Object.<anonymous> (/Users/sachinaugustine/sachin/adspostx/api-server/node_modules/@shopify/shopify-api/lib/webhooks/process.js:45:23)
    at Generator.next (<anonymous>)
    at fulfilled (/Users/sachinaugustine/sachin/adspostx/api-server/node_modules/tslib/tslib.js:166:62) {
  response: undefined
}

[kinngh]

The discussions and issues on this repository is not meant for your own code, but only for the repository. If you need help, please head over to the Discord, Shopify Community or somewhere else.

Just for your reference, I know you're not using this repository because

1. You're using CommonJS modules
2. You haven't bothered to check the Shopify/shopify-api-js docs
3. If your code is running into errors, you can literally copy/paste the routes in the code and be done with it.

[sachinaugi07]

okay @kinngh