New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails > 6.1 support select_all in query_cache breaks #26

Open

iambchan opened this issue Apr 15, 2021 · 0 comments

Contributor

iambchan commented Apr 15, 2021 •

edited

Loading

In the select_all method:

replica_pools/lib/replica_pools/query_cache.rb

Line 27 in 4c1a510

if !query_cache_enabled || locked?(relation)

We call locked? which is no longer supported in Rails 6.2.

Rails edge
https://github.com/rails/rails/blob/80a23227ea3bbf080c51f91efd8a0512ed038821/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb#L101

Rails 6.1
https://github.com/rails/rails/blob/6-1-stable/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb#L97

The text was updated successfully, but these errors were encountered:

iambchan changed the title ~~Rails 6.2 support select_all in query_cache breaks~~ Rails > 6.1 support select_all in query_cache breaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment