Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update Bouncy Castle #36

Open
Neustradamus opened this issue Jan 12, 2021 · 2 comments
Open

Please update Bouncy Castle #36

Neustradamus opened this issue Jan 12, 2021 · 2 comments

Comments

@jakubgs jakubgs closed this as completed Dec 6, 2022
@keycard-tech keycard-tech locked and limited conversation to collaborators Dec 6, 2022
@keycard-tech keycard-tech unlocked this conversation Dec 6, 2022
@jakubgs
Copy link

jakubgs commented Dec 6, 2022

Based on conversation in:

It appears we are indeed using this at runtime, but the CVE-2020-15522 doesn't appear to affect us.

@jakubgs jakubgs reopened this Dec 6, 2022
@bitgamma
Copy link
Contributor

bitgamma commented Dec 6, 2022

the reason why it hasn't been upgraded is that trying to do so generated builds of status-mobile which crashed at runtime. Since status-mobile is indirectly dependent on bouncycastle through other dependencies as well, I guessed it was some kind of conflict between required versions.

I have checked that CVE but it doesn't affect us because we don't use BouncyCastle for ECDSA signing. We use it for verifying, for ECDH, AES, DES and SHA in the context of Keycard. Outside Keycard I don't know exactly where it is used, but all blockchain related crypto is done in status-go so it is probably used for TLS (again, ECDH).

We could try again upgrading it and investigating what breaks the app at runtime, but unless there is a pressing reason to upgrade I would say it is low-prio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants