Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-assign PR to author not working #141

Open
Habitats opened this issue Jan 7, 2021 · 4 comments
Open

Auto-assign PR to author not working #141

Habitats opened this issue Jan 7, 2021 · 4 comments

Comments

@Habitats
Copy link

Habitats commented Jan 7, 2021

Describe the bug
Auto-assignment on PR not working anymore. It used to work, and without any config changes it just stopped.

This is our config:

addReviewers: false
addAssignees: author
skipKeywords:
  - wip
numberOfReviewers: 0

To Reproduce
Steps to reproduce the behavior:

  1. Open PR
  2. See error

Expected behavior
Author should be assigned to PR.

@dirien
Copy link

dirien commented May 12, 2021

I can confirm this too!

@jonasbn
Copy link

jonasbn commented May 21, 2021

I just tried with the following .github/auto_assign.yml and it worked:

# REF: https://probot.github.io/apps/auto-assign/

# Set to true to add reviewers to pull requests
addReviewers: true

# Set to true to add assignees to pull requests
addAssignees: 'author'

# A list of reviewers to be added to pull requests (GitHub user name)
reviewers:
  - jonasbn

# A list of keywords to be skipped the process that add reviewers if pull requests include it
#skipKeywords:
#  - wip

# A number of reviewers added to the pull request
# Set 0 to add all the reviewers (default: 0)
numberOfReviewers: 0

# A list of assignees, overrides reviewers if set
# assignees:
#  - jonasbn

# A number of assignees to add to the pull request
# Set to 0 to add all of the assignees.
# Uses numberOfReviewers if unset.
# numberOfAssignees: 2

Note that I have quoted the keyword author. I look at the code, which either takes a boolean or a string, so I thought I might as well try it.

First attempt was unsuccessful, since I only pushed the branch, the assignment was not made until the PR was created, which happened second time I tried.

See the PR for details.

@jonasbn
Copy link

jonasbn commented May 21, 2021

Never mind the above test, is also works without the quotes.

See my other PR for details

@brunowego
Copy link

I confirm this issue. If "quote" the author value works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants