Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add missing number of reviewers (if necessary) #137

Open
bobek opened this issue Nov 20, 2020 · 1 comment
Open

Only add missing number of reviewers (if necessary) #137

bobek opened this issue Nov 20, 2020 · 1 comment

Comments

@bobek
Copy link

bobek commented Nov 20, 2020

Is your feature request related to a problem? Please describe.
We have numberOfReviewers set to 2. Everything works as expected, bot will always add 2 new reviewers.

Describe the solution you'd like
I would like to be able to instruct bot not to add more then missing count of reviewers for PRs where I've already selected reviewers manually. I would expect, that numberOfReviewers behaves as a desired number of reviewers on the PR. For example:

  • PR has 0 reviewers -> bot will add 2
  • PR has 1 reviewer -> bot will add 1
  • PR has 2 and more reviewers -> bot will not add any new one

Alternatively we can introduce a new setting, something like maximumNumberOfReviewers for gating PRs which will get ignored by bot.

@hnandiwada
Copy link

I would love to see this implemented! I often have a specific reviewer in mind that I'd like to assign, and often find myself removing the bot's addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants