Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assignees when a draft PR is marked ready for review #136

Open
arminru opened this issue Oct 23, 2020 · 0 comments
Open

Add assignees when a draft PR is marked ready for review #136

arminru opened this issue Oct 23, 2020 · 0 comments

Comments

@arminru
Copy link

arminru commented Oct 23, 2020

Is your feature request related to a problem? Please describe.
Currently assignees are not added when a draft PR is marked ready for review, only when it is opened as ready right away.

Describe the solution you'd like
I'd expect assignees to be added once the draft PR is marked ready for review.

Additional context
I noticed that #105 introduced behavior intended to add assignees only once marked as ready, but apparently this does not work as expected. It added the following hook:

app.on('pull_request.ready_for_review', handlePullRequest)

If I understand the (quite sparse) documentation correctly, this hook/event does not apply when a draft PR is marked as ready for review but only when a non-draft PR is created, so the handler will not be called a second time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant