-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check PR body for skipKeywords #119
Comments
What do you think @kentaro-m? If I had to guess @swac, I think @kentaro-m would be open to a pull request. I opened one and he's been responsive, so I'd say go for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Our team uses this this action heavily, but we'd like the ability to override the auto-assignment for certain PRs, in particular ones where a developer knows precisely who should review a PR. Right now we often have to remove an auto-assigned reviewer, which creates unnecessary notifications. The existing
skipKeywords
feature only appears to check the PR title instead of also checking the PR body, which means we're forced to alter our PR title, and thus our squashed commit message title, just to conform to this action's requirements.Describe the solution you'd like
Either
skipKeywords
should check the PR's body for matching keywords or there should be a separateskipBodyKeywords
feature that matches based on body text.Describe alternatives you've considered
We can continue working around this by manually removing reviewers.
Additional context
I'm mostly interested in knowing whether this feature is something you think is valuable. If it is, I'm happy to send a PR to make the change 😄
The text was updated successfully, but these errors were encountered: