Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The RandAugment Implementation Is Wrong #39

Closed
psellcam opened this issue Jun 3, 2021 · 3 comments
Closed

The RandAugment Implementation Is Wrong #39

psellcam opened this issue Jun 3, 2021 · 3 comments

Comments

@psellcam
Copy link

psellcam commented Jun 3, 2021

google-research/fixmatch#65

As confirmed by the collaborator of the official implementation the randaugment function should be applied all the time not 50 percent of the time.

The only 50% chance from the original paper refers to the flips etc of weak augmentation only and definitely not the strong augmentation methods

This could explain why this repository does better than the original paper but it isn't what the original paper did.

For those who want the true performance of the original fixmatch paper you need to delete

if random.random() < 0.5:

From the https://github.com/kekmodel/FixMatch-pytorch/blob/master/dataset/randaugment.py file

@07Agarg
Copy link

07Agarg commented Jul 28, 2021

Hi @psellcam , thanks for pointing out the issue.
I believe then this if random.random() < 0.5: is removed from the class RandAugmentPC and the class RandAugmentMC.

Let me know if I understand this correctly. Thanks again.

@psellcam
Copy link
Author

Yes exactly!!

@kekmodel kekmodel closed this as completed Feb 9, 2022
@kekmodel kekmodel reopened this Feb 9, 2022
@kekmodel kekmodel closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants