Issue 10: Pick default namespace if no namespace is provided #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default namespace is getting selected if no namespace is provided.
It was tested with following flows
❯ kubectl secretdata default-ns-secret -o json { "default": { "default-ns-secret": { "password": "testpassword", "username": "testuser" } } } ❯ kubectl secretdata default-ns-secret default: default-ns-secret: password: testpassword username: testuser❯ kubectl secretdata default-ns-secret2 Error from server (NotFound): secrets "default-ns-secret2" not found❯ kubectl secretdata -A default: default-ns-secret: password: testpassword username: testuser istio-system: istio-ca-secret: ca-cert.pem: | -----BEGIN CERTIFICATE----- ................................................. -----END CERTIFICATE----- ca-key.pem: | -----BEGIN RSA PRIVATE KEY----- ................................................. -----END RSA PRIVATE KEY----- cert-chain.pem: "" key.pem: "" root-cert.pem: | -----BEGIN CERTIFICATE----- ................................................. -----END CERTIFICATE----- kube-system: bootstrap-token-abc: auth-extra-groups: system:bootstrappers:kubeadm:default-node-token expiration: "2024-09-21T13:56:03Z" test: test-ns-secret: password: testpassword2 username: testuser2❯ kubectl secretdata -m default,test default: default-ns-secret: password: testpassword username: testuser test: test-ns-secret: password: testpassword2 username: testuser2Closes #10