-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Condition not set for RollingUpgrade upon completion #321
Labels
bug
Something isn't working
Comments
Yes, looks like we are not updating conditions in new controller, we should address this. |
RIght. Missed updating the CR. Will Add it. Thanks @aweeks |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this a BUG REPORT or FEATURE REQUEST?:
Bug report
What happened:
kubectl wait
, egkubectl wait -n upgrade-manager rollingupgrade/xxx --for condition=complete
Interestingly, status is set, however:
This behavior changed somewhere between 0.13, and 1.0.4—in 0.13, the condition is set.
What you expected to happen:
Condition should be set, in addition to status.
How to reproduce it (as minimally and precisely as possible):
See "What happened".
Anything else we need to know?:
Environment:
keikoproj/rolling-upgrade-controller:v1.0.4
Other debugging information (if applicable):
The text was updated successfully, but these errors were encountered: