Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: awsprovider #294

Open
1 of 5 tasks
eytan-avisror opened this issue May 6, 2021 · 0 comments
Open
1 of 5 tasks

Refactor: awsprovider #294

eytan-avisror opened this issue May 6, 2021 · 0 comments
Labels
refactor

Comments

@eytan-avisror
Copy link
Collaborator

eytan-avisror commented May 6, 2021 •
edited

We should do some refactoring on awsprovider to simplify it and make it a bit more maintainable.

  • Split aws.go into multiple files according to service - ec2.go, autoscaling.go etc.
  • Rename AwsWorker to AmazonClientSet
  • Move Mocks from eks_test.go to aws_test.go so that it can be shared by other packages, currently mock implementation is repetitive between packages
  • Remove any unused methods
  • Remove Parameters from struct -> may require refactoring of eksmanaged/fargate provisioner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eytan-avisror