Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BDD test for LaunchConfig -> LaunchTemplate conversion #255

Open
backjo opened this issue Feb 12, 2021 · 0 comments
Open

Add BDD test for LaunchConfig -> LaunchTemplate conversion #255

backjo opened this issue Feb 12, 2021 · 0 comments
Projects
instance-manager
Milestone
0.13.0

Comments

@backjo
Copy link
Collaborator

backjo commented Feb 12, 2021

We should add a test for conversion from LaunchConfig to LaunchTemplate, to ensure that this conversion is handled correctly. #253 is an example of a case where it's easy to break this process by assuming that spec.LaunchTemplate implies that the scaling config is also a LaunchTemplate - which is correct, except for the conversion use case.
@eytan-avisror eytan-avisror added this to the 0.11.0 milestone Feb 12, 2021
@eytan-avisror eytan-avisror modified the milestones: 0.11.0, 0.12.0 May 1, 2021
@eytan-avisror eytan-avisror modified the milestones: 0.12.0, 0.13.0 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
instance-manager
To Do
Milestone
0.13.0
Development

No branches or pull requests
2 participants
@backjo @eytan-avisror