Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generic types issue in the upgrades functions #48

Open
jagodarybacka opened this issue Jan 23, 2024 · 0 comments
Open

Fix generic types issue in the upgrades functions #48

jagodarybacka opened this issue Jan 23, 2024 · 0 comments

Comments

@jagodarybacka
Copy link
Collaborator

Reference #46 (comment)

There is a problem with using typechain's contract interfaces like upgradeProxy<ContractTypeFromTypechain>() - the types don't match because typechain is creating types based on the ethers' BaseContract type but OpenZeppelin's upgradeProxy and deployProxy are returning ethers' Contract type - these are not interchangeable.

OpenZeppelin/openzeppelin-upgrades#535 would probably fix this issue but is not merged yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jagodarybacka