Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minReplicas, maxReplicas and idleReplicas check bug for scaleobject #6356

Open
ctccxxd opened this issue Nov 21, 2024 · 0 comments
Open

minReplicas, maxReplicas and idleReplicas check bug for scaleobject #6356

ctccxxd opened this issue Nov 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ctccxxd
Copy link

ctccxxd commented Nov 21, 2024

Report

when user config a fallback part in a scaleobject, the related webhook module check take no effect. The code has been in the project main branch, but take no effect yet. Besides, there is no negative check in code.
code3

Expected Behavior

When user have misconfiguration, such as maxReplicas, minRelicas or idleReplicas value. The webhook should not validate it.

Actual Behavior

Validate it even for maxReplicas, minRelicas or idleReplicas value. Even when maxRelicas is negative, it will be passed to HPA.

Steps to Reproduce the Problem

I have contribute my code, welcome to review #6344.

Logs from KEDA operator

No

KEDA Version

main branch

Kubernetes Version

None

Platform

None

Scaler Details

No response

Anything else?

No response

@ctccxxd ctccxxd added the bug Something isn't working label Nov 21, 2024
@ctccxxd ctccxxd changed the title replicas check bug for scaleobject minReplicas, maxReplicas and idleReplicas check bug for scaleobject Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To Triage
Development

No branches or pull requests

1 participant