Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-consecutive duplicate keys don't trigger duplicate key error #586

Open
1 task done
RedEtherbloom opened this issue Jun 11, 2024 · 0 comments
Open
1 task done
Labels
bug Something isn't working

Comments

@RedEtherbloom
Copy link
Collaborator

Describe the bug

Conflicting non-consecutive keybindings in the duplicate key check array in check() don't trigger the duplicate key error.
The Vector that is used for checking key duplication is not sorted, therefore dedup does not spot these.

To Reproduce

Steps to reproduce the behavior:
Set quit and previous-tab(example conflict) to the same keybinding
or
Execute ignored test in branch RedEtherbloom/taskwarrior-tui/duplicate_key_fix

cargo test -- keyconfig::tests::test_duplicate_key_error --ignored

Environment (please complete the following information):

  • Operating System: Linux / NixOS
  • Installation: local cargo build
  • taskwarrior-tui version: 0.26.3
@RedEtherbloom RedEtherbloom added the bug Something isn't working label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant