-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: CEL validation of PermissionClaims.ResourceSelector.Namespaces not compiling or passing tests #2898
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. /close |
@kcp-ci-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Describe the bug
As part of #2456, a CEL validation rule was added to the
PermissionClaims.ResourceSelector.Namespaces
field to disallow the empty string (""
) anywhere in the list.However, this test is not passing and the
validator
function created from the rule seems to be a no-op based on debugging information.Steps To Reproduce
pkg/apis/apis/v1alpha1/types_apiexport_test.go
and remove thet.Skip
statementcd pkg/apis && go test ./apis/v1alpha1 -run TestAPIExportPermissionClaimNamespace
Expected Behaviour
The CEL validation function should be constructed, but for some reason stepping into it all the fields are set to nil. Possibly a bug in our parsing logic?
Additional Context
No response
The text was updated successfully, but these errors were encountered: