Use correct token id reference for combatant #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sgt-Pepper
approved these changes
Jul 19, 2021
|
Fixes #70 with VTT 0.8.8 and PF2E 2.9.1 |
STBaf
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
This change seem to fix the prolem in all tested circumstances (fresh world with ds4 and turnmarker only, 2 running campaign worlds with multiple active other modules). Marker is seen and correctly positioned after applying this patch manuel to the installed module. (VTT 0.8.8 with ds4 1.2.1)
|
I've merged this change into main already from another PR. Sorry, been pretty busy at work, and never got the time to come back and nail down this bug. It should be working on the current release. It was part of this larger PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolved #70 for me.