-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate: cleanup listeners #299
Comments
review async client and come up with recommendation |
The two main issues that made the need for new listeners are: About tracingUnder the hood Proxy Wasm's Therefore: the changes needed to support creating new spans in wasm do not need to reach into the AsyncClient code. They solely need to affect the WASM layers in Envoy, all the way to WASM's interaction with the async client.. Access LogAs it turns out, the Async Client does not have Access Logging infrastructure in it. It seems from reading comments (for instance this one) that there was an intention to hook on Access Logging onto the Async Client, but it hasn't materialized. IMO the lift is considerable given that Access Logging is a publicly configurable entity in Envoy, but Async Clients are not. i.e, I am not sure what exposing the concept of an AsyncClient client would mean for Envoy. My initial glimmer of possibility would be to expose the Access Logging configuration under the Cluster configuration given that internally the "Cluster" is what (through some indirection) spawns an AsyncClient. |
This will be great. That means we can get parent |
We should have two listeners one for prompt and other for llm routing.
Here is a list of listeners we have today,
The text was updated successfully, but these errors were encountered: