Video Embedding in cucumber json

[CPogX]

Videos are not embedding correctly in the cucumber reports. This is because of how they are embedded into the cucumber json files.

com.intuit.karate.core.Embed has a toMap() function with conditional logic for video/mp4 to to encode the HTML tag and text/html instead of encoding the video and using video/mp4. This works for the HTML reports, but not for the cucumber reports.

Removing the conditional logic for videos, and handling them the same way as every other content type:

map.put("data", this.getBase64());
map.put("mime_type", this.resourceType.contentType);

resolved the issue with the cucumber reports, and the html reports still worked. I have tested with karate-chrome, and using karate.embed. Is there a scenario I am not considering/ can I raise a pr?

[ptrthomas]

@CPogX possible duplicate of #2121 - do check, but in any case you can go ahead with a PR

[CPogX]

@ptrthomas 100% a duplicate. Created pr #2638.

[ptrthomas]

cc @bischoffdev just FYI